Remove some unused code from csrc/runtime
#5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think |
This reverts commit ebe4567.
|
Got it. Switched our code to use the upstream copy of |
JackCaoG
approved these changes
Nov 10, 2023
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
zpcore
pushed a commit
that referenced
this pull request
Nov 21, 2023
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
lsy323
pushed a commit
to lsy323/xla
that referenced
this pull request
Nov 28, 2023
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* delete nccl_distributed * remove async_task * remove unique * Remove hashing * more random cleanup * formatting * remove util.cc * Revert "remove unique" This reverts commit ebe4567. * Use upstream Unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nccl_distributedandasync_taskare completely unusedUniquealready exist upstreamutil.hMultiWaitis also duplicated upstream, but I have separate plans for that one.